Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44e33e8f authored by Greg Thelen's avatar Greg Thelen Committed by Linus Torvalds
Browse files

res_counter: delete res_counter_write() 



Since commit 628f4235 ("memcg: limit change shrink usage") both
res_counter_write() and write_strategy_fn have been unused.  This patch
deletes them both.

Signed-off-by: default avatarGreg Thelen <gthelen@google.com>
Cc: Glauber Costa <glommer@parallels.com>
Cc: Tejun Heo <tj@kernel.org>
Acked-by: default avatarKAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Frederic Weisbecker <fweisbec@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6715ddf9

include/linux/res_counter.h

+0 −5
Original line number Diff line number Diff line
@@ -74,14 +74,9 @@ ssize_t res_counter_read(struct res_counter *counter, int member, 
		const char __user *buf, size_t nbytes, loff_t *pos,

		int (*read_strategy)(unsigned long long val, char *s));



typedef int (*write_strategy_fn)(const char *buf, unsigned long long *val);



int res_counter_memparse_write_strategy(const char *buf,

					unsigned long long *res);



int res_counter_write(struct res_counter *counter, int member,

		      const char *buffer, write_strategy_fn write_strategy);



/*

 * the field descriptors. one for each member of res_counter

 */

kernel/res_counter.c

+0 −22
Original line number Diff line number Diff line
@@ -192,25 +192,3 @@ int res_counter_memparse_write_strategy(const char *buf, 
	*res = PAGE_ALIGN(*res);

	return 0;

}
 


int res_counter_write(struct res_counter *counter, int member,

		      const char *buf, write_strategy_fn write_strategy)

{

	char *end;

	unsigned long flags;

	unsigned long long tmp, *val;



	if (write_strategy) {

		if (write_strategy(buf, &tmp))

			return -EINVAL;

	} else {

		tmp = simple_strtoull(buf, &end, 10);

		if (*end != '\0')

			return -EINVAL;

	}

	spin_lock_irqsave(&counter->lock, flags);

	val = res_counter_member(counter, member);

	*val = tmp;

	spin_unlock_irqrestore(&counter->lock, flags);

	return 0;

}