Commit 441e17f7 authored Mar 31, 2018 by Nathan Chancellor Committed by Amit Pundir Aug 30, 2018

ANDROID: xt_qtaguid: Remove unnecessary null checks to device's name



'name' will never be NULL since it isn't a plain pointer but an array
of char values.

../net/netfilter/xt_qtaguid.c:1195:27: warning: address of array
'(*el_dev)->name' will always evaluate to 'true'
[-Wpointer-bool-conversion]
        if (unlikely(!(*el_dev)->name)) {
                     ~~~~~~~~~~~~^~~~

Change-Id: If3b25f17829b43e8a639193fb9cd04ae45947200
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
(cherry picked from android-4.4 commit 207b579e3db6fd0cb6fe40ba3e929635ad748d89)
Signed-off-by: Chenbo Feng <fengc@google.com>

parent b4d74821

net/netfilter/xt_qtaguid.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -1194,11 +1194,6 @@ static void get_dev_and_dir(const struct sk_buff *skb,
		parst->hook, __func__);
		BUG();
		}
		if (unlikely(!(*el_dev)->name)) {
		pr_err("qtaguid[%d]: %s(): no dev->name?!!\n",
		parst->hook, __func__);
		BUG();
		}
		if (skb->dev && *el_dev != skb->dev) {
		MT_DEBUG("qtaguid[%d]: skb->dev=%p %s vs par->%s=%p %s\n",
		parst->hook, skb->dev, skb->dev->name,