Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43b9a9c7 authored by Hangyu Hua's avatar Hangyu Hua Committed by Greg Kroah-Hartman
Browse files

netfilter: ctnetlink: fix possible refcount leak in ctnetlink_create_conntrack() 



[ Upstream commit ac4893980bbe79ce383daf9a0885666a30fe4c83 ]

nf_ct_put() needs to be called to put the refcount got by
nf_conntrack_find_get() to avoid refcount leak when
nf_conntrack_hash_check_insert() fails.

Fixes: 7d367e06 ("netfilter: ctnetlink: fix soft lockup when netlink adds new entries (v2)")
Signed-off-by: default avatarHangyu Hua <hbh25y@gmail.com>
Acked-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 6ff51a99

net/netfilter/nf_conntrack_netlink.c

+4 −1
Original line number Diff line number Diff line
@@ -2056,12 +2056,15 @@ ctnetlink_create_conntrack(struct net *net, 


	err = nf_conntrack_hash_check_insert(ct);

	if (err < 0)

		goto err2;

		goto err3;



	rcu_read_unlock();



	return ct;



err3:

	if (ct->master)

		nf_ct_put(ct->master);

err2:

	rcu_read_unlock();

err1: