Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43270b1b authored by Pablo Neira Ayuso's avatar Pablo Neira Ayuso
Browse files

netfilter: ipt_CLUSTERIP: deprecate it in favour of xt_cluster 

xt_cluster supersedes ipt_CLUSTERIP since it can be also used in
gateway configurations (not only from the backend side).

ipt_CLUSTER is also known to leak the netdev that it uses on
device removal, which requires a rather large fix to workaround
the problem: http://patchwork.ozlabs.org/patch/358629/



So let's deprecate this so we can probably kill code this in the
future.

Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 72500bc1

include/net/netns/x_tables.h

+1 −0
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ struct ebt_table; 
struct netns_xt {

	struct list_head tables[NFPROTO_NUMPROTO];

	bool notrack_deprecated_warning;

	bool clusterip_deprecated_warning;

#if defined(CONFIG_BRIDGE_NF_EBTABLES) || \

    defined(CONFIG_BRIDGE_NF_EBTABLES_MODULE)

	struct ebt_table *broute_table;

net/ipv4/netfilter/ipt_CLUSTERIP.c

+7 −0
Original line number Diff line number Diff line
@@ -418,6 +418,13 @@ static int clusterip_tg_check(const struct xt_tgchk_param *par) 
	if (ret < 0)

		pr_info("cannot load conntrack support for proto=%u\n",

			par->family);



	if (!par->net->xt.clusterip_deprecated_warning) {

		pr_info("ipt_CLUSTERIP is deprecated and it will removed soon, "

			"use xt_cluster instead\n");

		par->net->xt.clusterip_deprecated_warning = true;

	}



	return ret;

}