Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 42fd3638 authored by Prabhakar Lad's avatar Prabhakar Lad Committed by Mauro Carvalho Chehab
Browse files

[media] media: am437x: fix sparse warnings 



This patch fixes following spare warnings:

drivers/media/platform/am437x/am437x-vpfe.c:66:28: warning: symbol 'vpfe_standards' was not declared. Should it be static?
drivers/media/platform/am437x/am437x-vpfe.c:2202:57: warning: incorrect type in argument 2 (different address spaces)
drivers/media/platform/am437x/am437x-vpfe.c:2202:57:    expected void [noderef] <asn:1>*params
drivers/media/platform/am437x/am437x-vpfe.c:2202:57:    got void *param
include/linux/spinlock.h:364:9: warning: context imbalance in 'vpfe_start_streaming' - unexpected unlock

Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarLad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 3edf7eb8

drivers/media/platform/am437x/am437x-vpfe.c

+2 −3
Original line number Diff line number Diff line
@@ -63,7 +63,7 @@ struct vpfe_standard { 
	int frame_format;

};



const struct vpfe_standard vpfe_standards[] = {

static const struct vpfe_standard vpfe_standards[] = {

	{V4L2_STD_525_60, 720, 480, {11, 10}, 1},

	{V4L2_STD_625_50, 720, 576, {54, 59}, 1},

};
@@ -2024,7 +2024,6 @@ static int vpfe_start_streaming(struct vb2_queue *vq, unsigned int count) 
		list_del(&buf->list);

		vb2_buffer_done(&buf->vb, VB2_BUF_STATE_QUEUED);

	}

	spin_unlock_irqrestore(&vpfe->dma_queue_lock, flags);



	return ret;

}
@@ -2199,7 +2198,7 @@ static long vpfe_ioctl_default(struct file *file, void *priv, 


	switch (cmd) {

	case VIDIOC_AM437X_CCDC_CFG:

		ret = vpfe_ccdc_set_params(&vpfe->ccdc, param);

		ret = vpfe_ccdc_set_params(&vpfe->ccdc, (void __user *)param);

		if (ret) {

			vpfe_dbg(2, vpfe,

				"Error setting parameters in CCDC\n");