Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 42ee19e2 authored by Jarno Rajahalme's avatar Jarno Rajahalme Committed by Jesse Gross
Browse files

openvswitch: Fix race. 



ovs_vport_cmd_dump() did rcu_read_lock() only after getting the
datapath, which could have been deleted in between.  Resolved by
taking rcu_read_lock() before the get_dp() call.

Signed-off-by: default avatarJarno Rajahalme <jrajahalme@nicira.com>
Signed-off-by: default avatarPravin B Shelar <pshelar@nicira.com>
parent 04382a33

net/openvswitch/datapath.c

+4 −3
Original line number Diff line number Diff line
@@ -1762,11 +1762,12 @@ static int ovs_vport_cmd_dump(struct sk_buff *skb, struct netlink_callback *cb) 
	int bucket = cb->args[0], skip = cb->args[1];

	int i, j = 0;



	rcu_read_lock();

	dp = get_dp(sock_net(skb->sk), ovs_header->dp_ifindex);

	if (!dp)

	if (!dp) {

		rcu_read_unlock();

		return -ENODEV;



	rcu_read_lock();

	}

	for (i = bucket; i < DP_VPORT_HASH_BUCKETS; i++) {

		struct vport *vport;