Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 42c36295 authored by alex.bluesman.smirnov@gmail.com's avatar alex.bluesman.smirnov@gmail.com Committed by David S. Miller
Browse files

6lowpan: revert 'reuse eth_mac_addr()' 



This reverts the commit cdf49c28 which
replaces lowpan '.ndo_set_mac_address' method by ethernet's one.

Accorind to the IEEE 802.15.4 standard, device has 8-byte length address,
so this hook loses the last 2 bytes which may rise a compatibility problems
with other IEEE 802.15.4 standard implementations.

Signed-off-by: default avatarAlexander Smirnov <alex.bluesman.smirnov@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0979e465

net/ieee802154/6lowpan.c

+14 −2
Original line number Diff line number Diff line
@@ -55,7 +55,6 @@ 
#include <linux/module.h>

#include <linux/moduleparam.h>

#include <linux/netdevice.h>

#include <linux/etherdevice.h>

#include <net/af_ieee802154.h>

#include <net/ieee802154.h>

#include <net/ieee802154_netdev.h>
@@ -936,6 +935,19 @@ lowpan_process_data(struct sk_buff *skb) 
	return -EINVAL;

}



static int lowpan_set_address(struct net_device *dev, void *p)

{

	struct sockaddr *sa = p;



	if (netif_running(dev))

		return -EBUSY;



	/* TODO: validate addr */

	memcpy(dev->dev_addr, sa->sa_data, dev->addr_len);



	return 0;

}



static int lowpan_get_mac_header_length(struct sk_buff *skb)

{

	/*
@@ -1078,7 +1090,7 @@ static struct header_ops lowpan_header_ops = { 


static const struct net_device_ops lowpan_netdev_ops = {

	.ndo_start_xmit		= lowpan_xmit,

	.ndo_set_mac_address	= eth_mac_addr,

	.ndo_set_mac_address	= lowpan_set_address,

};



static struct ieee802154_mlme_ops lowpan_mlme = {