Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 42ae2922 authored by Matthias Kaehlcke's avatar Matthias Kaehlcke Committed by Herbert Xu
Browse files

crypto: arm64/sha - Add constant operand modifier to ASM_EXPORT 



The operand is an integer constant, make the constness explicit by
adding the modifier. This is needed for clang to generate valid code
and also works with gcc.

Also change the constraint of the operand from 'I' ("Integer constant
that is valid as an immediate operand in an ADD instruction", AArch64)
to 'i' ("An immediate integer operand").

Based-on-patch-from: Greg Hackmann <ghackmann@google.com>
Signed-off-by: default avatarGreg Hackmann <ghackmann@google.com>
Signed-off-by: default avatarMatthias Kaehlcke <mka@chromium.org>
Reviewed-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent ad1064cd

arch/arm64/crypto/sha1-ce-glue.c

+1 −1
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ 
#include <linux/module.h>



#define ASM_EXPORT(sym, val) \

	asm(".globl " #sym "; .set " #sym ", %0" :: "I"(val));

	asm(".globl " #sym "; .set " #sym ", %c0" :: "i"(val));



MODULE_DESCRIPTION("SHA1 secure hash using ARMv8 Crypto Extensions");

MODULE_AUTHOR("Ard Biesheuvel <ard.biesheuvel@linaro.org>");

arch/arm64/crypto/sha2-ce-glue.c

+1 −1
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ 
#include <linux/module.h>



#define ASM_EXPORT(sym, val) \

	asm(".globl " #sym "; .set " #sym ", %0" :: "I"(val));

	asm(".globl " #sym "; .set " #sym ", %c0" :: "i"(val));



MODULE_DESCRIPTION("SHA-224/SHA-256 secure hash using ARMv8 Crypto Extensions");

MODULE_AUTHOR("Ard Biesheuvel <ard.biesheuvel@linaro.org>");