Commit 4237081e authored Feb 20, 2007 by Jiri Kosina

HID: fix bug in zeroing the last field byte in output reports



d4ae650a introduced zeroing of the
last field byte in output reports in order to make sure the unused
bits are set to 0. This is done in a wrong way, resulting in a
wrong bits being zeroed out (not properly shifted by the field offset
in the report). Fix this.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent fdc9c566

drivers/hid/hid-core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -880,7 +880,7 @@ static void hid_output_field(struct hid_field field, __u8 data)

		/* make sure the unused bits in the last byte are zeros */
		if (count > 0 && size > 0)
		data[(count*size-1)/8] = 0;
		data[(offset+count*size-1)/8] = 0;

		for (n = 0; n < count; n++) {
		if (field->logical_minimum < 0) /* signed values */