Commit 418d59ef authored Apr 15, 2017 by Dan Carpenter Committed by Boris Brezillon Apr 18, 2017

drm: atmel-hlcdc: Uninitialized return in atmel_hlcdc_create_outputs()

It's not possible for endpoint to be zero so the test doesn't work. If
we break on the first iteration through the loop then endpoint is 1 and
"ret" is uninitialized.

Fixes: ebc94461 ("drm: convert drivers to use drm_of_find_panel_or_bridge")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170415192142.GA6416@mwanda

parent 2f410f88

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -221,7 +221,8 @@ static int atmel_hlcdc_attach_endpoint(struct drm_device *dev,
		int atmel_hlcdc_create_outputs(struct drm_device *dev)
		{
		struct device_node *remote;
		int ret, endpoint = 0;
		int ret = -ENODEV;
		int endpoint = 0;

		while (true) {
		/* Loop thru possible multiple connections to the output */
		@@ -236,7 +237,5 @@ int atmel_hlcdc_create_outputs(struct drm_device *dev)
		return ret;
		}

		if (!endpoint)
		return -ENODEV;
		return ret;
		}