Commit 4169591f authored Aug 24, 2010 by Dan Carpenter Committed by David S. Miller Aug 24, 2010

pxa168_eth: remove unneeded null check



"pep->pd" isn't checked consistently in this function.  For example it's
dereferenced unconditionally on the next line after the end of the if
condition.  This function is only called from pxa168_eth_probe() and
pep->pd is always non-NULL so I removed the check.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ef24b16b

drivers/net/pxa168_eth.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1414,10 +1414,8 @@ static int ethernet_phy_setup(struct net_device *dev)
		{
		struct pxa168_eth_private *pep = netdev_priv(dev);

		if (pep->pd != NULL) {
		if (pep->pd->init)
		pep->pd->init();
		}
		pep->phy = phy_scan(pep, pep->pd->phy_addr & 0x1f);
		if (pep->phy != NULL)
		phy_init(pep, pep->pd->speed, pep->pd->duplex);