Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4158dbe1 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Inki Dae
Browse files

Subject: [PATCH, RESEND] drm: exynos: avoid unused function warning 



When CONFIG_PM is not set, we get a warning about an unused function:

drivers/gpu/drm/exynos/exynos_drm_gsc.c:1219:12: error: 'gsc_clk_ctrl' defined but not used [-Werror=unused-function]
 static int gsc_clk_ctrl(struct gsc_context *ctx, bool enable)
            ^~~~~~~~~~~~

This removes the two #ifdef checks in this file and instead marks the
functions as __maybe_unused, which is a more reliable way of doing the
same, allowing better build coverage and avoiding the warning above.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
parent b05984e2

drivers/gpu/drm/exynos/exynos_drm_gsc.c

+2 −4
Original line number Diff line number Diff line
@@ -1760,8 +1760,7 @@ static int gsc_remove(struct platform_device *pdev) 
	return 0;

}



#ifdef CONFIG_PM

static int gsc_runtime_suspend(struct device *dev)

static int __maybe_unused gsc_runtime_suspend(struct device *dev)

{

	struct gsc_context *ctx = get_gsc_context(dev);
@@ -1770,7 +1769,7 @@ static int gsc_runtime_suspend(struct device *dev) 
	return  gsc_clk_ctrl(ctx, false);

}



static int gsc_runtime_resume(struct device *dev)

static int __maybe_unused gsc_runtime_resume(struct device *dev)

{

	struct gsc_context *ctx = get_gsc_context(dev);
@@ -1778,7 +1777,6 @@ static int gsc_runtime_resume(struct device *dev) 


	return  gsc_clk_ctrl(ctx, true);

}

#endif



static const struct dev_pm_ops gsc_pm_ops = {

	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,