Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41147bfd authored by Thomas Abraham's avatar Thomas Abraham Committed by Greg Kroah-Hartman
Browse files

serial: samsung: remove the use of statically remapped controller address 



The address S3C_VA_UART is a statically ioremapped address. The driver
should not be using this. Instead, the driver should setup a mapping
during probe.

Cc: Kukjin Kim <kgene.kim@samsung.com>
Signed-off-by: default avatarThomas Abraham <thomas.abraham@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 81a7d777

drivers/tty/serial/samsung.c

+6 −2
Original line number Diff line number Diff line
@@ -47,7 +47,6 @@ 
#include <asm/irq.h>



#include <mach/hardware.h>

#include <mach/map.h>



#include <plat/regs-serial.h>

#include <plat/clock.h>
@@ -1144,8 +1143,13 @@ static int s3c24xx_serial_init_port(struct s3c24xx_uart_port *ourport, 


	dbg("resource %p (%lx..%lx)\n", res, res->start, res->end);



	port->membase = devm_ioremap(port->dev, res->start, resource_size(res));

	if (!port->membase) {

		dev_err(port->dev, "failed to remap controller address\n");

		return -EBUSY;

	}



	port->mapbase = res->start;

	port->membase = S3C_VA_UART + (res->start & 0xfffff);

	ret = platform_get_irq(platdev, 0);

	if (ret < 0)

		port->irq = 0;