Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 410fe39c authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

ASoC: cs35l33: Fix testing return value of devm_gpiod_get_optional 



devm_gpiod_get_optional() returns NULL when the gpio is not assigned.
So the if (PTR_ERR(cs35l33->reset_gpio) == -ENOENT) test is always false.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Acked-by: default avatarPaul Handrigan <Paul.Handrigan@cirrus.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 20f12f2c

sound/soc/codecs/cs35l33.c

+1 −5
Original line number Diff line number Diff line
@@ -1176,11 +1176,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client, 
	/* We could issue !RST or skip it based on AMP topology */

	cs35l33->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev,

			"reset-gpios", GPIOD_OUT_HIGH);



	if (PTR_ERR(cs35l33->reset_gpio) == -ENOENT) {

		dev_warn(&i2c_client->dev,

			"%s WARNING: No reset gpio assigned\n", __func__);

	} else if (IS_ERR(cs35l33->reset_gpio)) {

	if (IS_ERR(cs35l33->reset_gpio)) {

		dev_err(&i2c_client->dev, "%s ERROR: Can't get reset GPIO\n",

			__func__);

		return PTR_ERR(cs35l33->reset_gpio);