Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 40d25904 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

mlxsw: spectrum_router: Fix error path in mlxsw_sp_router_init 



When neigh_init fails, we have to do proper cleanup including
router_fini call.

Fixes: 6cf3c971 ("mlxsw: spectrum_router: Add private neigh table")
Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Acked-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2c2c8e33

drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

+8 −1
Original line number Diff line number Diff line
@@ -1517,7 +1517,14 @@ int mlxsw_sp_router_init(struct mlxsw_sp *mlxsw_sp) 
		return err;

	mlxsw_sp_lpm_init(mlxsw_sp);

	mlxsw_sp_vrs_init(mlxsw_sp);

	return mlxsw_sp_neigh_init(mlxsw_sp);

	err = mlxsw_sp_neigh_init(mlxsw_sp);

	if (err)

		goto err_neigh_init;

	return 0;



err_neigh_init:

	__mlxsw_sp_router_fini(mlxsw_sp);

	return err;

}



void mlxsw_sp_router_fini(struct mlxsw_sp *mlxsw_sp)