Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 40ad5b37 authored by Shawn Guo's avatar Shawn Guo
Browse files

dmaengine: imx-sdma: sdma_get_firmware does not need to copy fw_name 



It does not need to allocate space and copy fw_name in function
sdma_get_firmware().

Signed-off-by: default avatarShawn Guo <shawn.guo@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 62550cd7

drivers/dma/imx-sdma.c

+2 −10
Original line number Diff line number Diff line
@@ -1126,22 +1126,14 @@ static int __init sdma_get_firmware(struct sdma_engine *sdma, 
		const char *fw_name)

{

	const struct firmware *fw;

	char *fwname;

	const struct sdma_firmware_header *header;

	int ret;

	const struct sdma_script_start_addrs *addr;

	unsigned short *ram_code;



	fwname = kasprintf(GFP_KERNEL, "%s", fw_name);

	if (!fwname)

		return -ENOMEM;



	ret = request_firmware(&fw, fwname, sdma->dev);

	if (ret) {

		kfree(fwname);

	ret = request_firmware(&fw, fw_name, sdma->dev);

	if (ret)

		return ret;

	}

	kfree(fwname);



	if (fw->size < sizeof(*header))

		goto err_firmware;