Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 405010df authored by Wei Yongjun's avatar Wei Yongjun Committed by Konrad Rzeszutek Wilk
Browse files

xen-pciback: fix error return code in pcistub_irq_handler_switch() 



Fix to return -ENOENT in the pcistub_device_find() and pci_get_drvdata()
error handling case instead of 0(overwrite to 0 by str_to_slot()), as done
elsewhere in this function.

Acked-by: default avatarJan Beulich <jbeulich@suse.com>
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
parent 8d0b8801

drivers/xen/xen-pciback/pci_stub.c

+7 −3
Original line number Diff line number Diff line
@@ -1196,19 +1196,23 @@ static ssize_t pcistub_irq_handler_switch(struct device_driver *drv, 
	struct pcistub_device *psdev;

	struct xen_pcibk_dev_data *dev_data;

	int domain, bus, slot, func;

	int err = -ENOENT;

	int err;



	err = str_to_slot(buf, &domain, &bus, &slot, &func);

	if (err)

		return err;



	psdev = pcistub_device_find(domain, bus, slot, func);

	if (!psdev)

	if (!psdev) {

		err = -ENOENT;

		goto out;

	}



	dev_data = pci_get_drvdata(psdev->dev);

	if (!dev_data)

	if (!dev_data) {

		err = -ENOENT;

		goto out;

	}



	dev_dbg(&psdev->dev->dev, "%s fake irq handler: %d->%d\n",

		dev_data->irq_name, dev_data->isr_on,