Commit 400c18e3 authored Apr 18, 2017 by Marek Vasut Committed by Mark Brown Apr 18, 2017

spi: dw: Disable clock after unregistering the host



The dw_mmio driver disables the block clock before unregistering
the host. The code unregistering the host may access the SPI block
registers. If register access happens with block clock disabled,
this may lead to a bus hang. Disable the clock after unregistering
the host to prevent such situation.

This bug was observed on Altera Cyclone V SoC.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent fafd6794

drivers/spi/spi-dw-mmio.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -115,8 +115,8 @@ static int dw_spi_mmio_remove(struct platform_device *pdev)
		{
		struct dw_spi_mmio *dwsmmio = platform_get_drvdata(pdev);

		clk_disable_unprepare(dwsmmio->clk);
		dw_spi_remove_host(&dwsmmio->dws);
		clk_disable_unprepare(dwsmmio->clk);

		return 0;
		}