Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3fe968f1 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds
Browse files

[PATCH] blkmtd: use clear_page_dirty() 



SetPageDirty() and ClearPageDirty() are low-level thing which filesystems
shouldn't be using.  They bypass dirty page accounting.

Cc: David Woodhouse <dwmw2@infradead.org>
Acked-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 67121172

drivers/mtd/devices/blkmtd.c

+4 −4
Original line number Diff line number Diff line
@@ -113,7 +113,7 @@ static int bi_write_complete(struct bio *bio, unsigned int bytes_done, int error 
			ClearPageUptodate(page);

			SetPageError(page);

		}

		ClearPageDirty(page);

		clear_page_dirty(page);

		unlock_page(page);

		page_cache_release(page);

	} while (bvec >= bio->bi_io_vec);
@@ -289,7 +289,7 @@ static int write_pages(struct blkmtd_dev *dev, const u_char *buf, loff_t to, 
			BUG();

		}

		memcpy(page_address(page)+offset, buf, start_len);

		SetPageDirty(page);

		set_page_dirty(page);

		SetPageUptodate(page);

		buf += start_len;

		thislen = start_len;
@@ -336,7 +336,7 @@ static int write_pages(struct blkmtd_dev *dev, const u_char *buf, loff_t to, 
			}

			pagenr++;

			pagecnt--;

			SetPageDirty(page);

			set_page_dirty(page);

			SetPageUptodate(page);

			pagesc--;

			thislen += PAGE_SIZE;
@@ -357,7 +357,7 @@ static int write_pages(struct blkmtd_dev *dev, const u_char *buf, loff_t to, 
			BUG();

		}

		memcpy(page_address(page), buf, end_len);

		SetPageDirty(page);

		set_page_dirty(page);

		SetPageUptodate(page);

		DEBUG(3, "blkmtd: write: writing out partial end\n");

		thislen += end_len;