Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f6bcc51 authored by YueHaibing's avatar YueHaibing Committed by David S. Miller
Browse files

act_bpf: Use kmemdup instead of duplicating it in tcf_bpf_init_from_ops 



Replace calls to kmalloc followed by a memcpy with a direct call to
kmemdup.

Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Acked-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f9562fa4

net/sched/act_bpf.c

+1 −3
Original line number Diff line number Diff line
@@ -196,12 +196,10 @@ static int tcf_bpf_init_from_ops(struct nlattr **tb, struct tcf_bpf_cfg *cfg) 
	if (bpf_size != nla_len(tb[TCA_ACT_BPF_OPS]))

		return -EINVAL;



	bpf_ops = kzalloc(bpf_size, GFP_KERNEL);

	bpf_ops = kmemdup(nla_data(tb[TCA_ACT_BPF_OPS]), bpf_size, GFP_KERNEL);

	if (bpf_ops == NULL)

		return -ENOMEM;



	memcpy(bpf_ops, nla_data(tb[TCA_ACT_BPF_OPS]), bpf_size);



	fprog_tmp.len = bpf_num_ops;

	fprog_tmp.filter = bpf_ops;