Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f0b3cf4 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFS: Filter cache invalidation when holding a delegation 



If the client holds a delegation, then ensure we filter out attempts
to invalidate the size, owner, group owner, or mode unless we made the
change, in which case, check that NFS_INO_REVAL_FORCED is set by the
caller.
Always filter out attempts to invalidate the change attribute and
size, since we are authoritative for those.

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent 4ebe83af

fs/nfs/inode.c

+9 −3
Original line number Diff line number Diff line
@@ -195,10 +195,16 @@ bool nfs_check_cache_invalid(struct inode *inode, unsigned long flags) 
static void nfs_set_cache_invalid(struct inode *inode, unsigned long flags)

{

	struct nfs_inode *nfsi = NFS_I(inode);

	bool have_delegation = nfs_have_delegated_attributes(inode);

	bool have_delegation = NFS_PROTO(inode)->have_delegation(inode, FMODE_READ);



	if (have_delegation) {

		if (!(flags & NFS_INO_REVAL_FORCED))

			flags &= ~NFS_INO_INVALID_OTHER;

		flags &= ~(NFS_INO_INVALID_CHANGE

				| NFS_INO_INVALID_SIZE

				| NFS_INO_REVAL_PAGECACHE);

	}



	if (have_delegation)

		flags &= ~(NFS_INO_INVALID_CHANGE|NFS_INO_REVAL_PAGECACHE);

	if (inode->i_mapping->nrpages == 0)

		flags &= ~NFS_INO_INVALID_DATA;

	nfsi->cache_validity |= flags;