Commit 3eb23426 authored Nov 17, 2017 by Colin Ian King Committed by Greg Kroah-Hartman Nov 28, 2017

staging: rtl8822be: fix missing null check on dev_alloc_skb return



dev_alloc_skb can potentially return NULL, so add a null check to
avoid a null pointer dereference on skb

Detected by CoverityScan, CID#1454558 ("Dereference on null return")

Fixes: 7e5b796c ("staging: r8822be: Add the driver code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent dcfe0238

drivers/staging/rtlwifi/rtl8822be/fw.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -464,6 +464,8 @@ bool rtl8822b_halmac_cb_write_data_rsvd_page(struct rtl_priv rtlpriv, u8 buf,
		int count;

		skb = dev_alloc_skb(size);
		if (!skb)
		return false;
		memcpy((u8 *)skb_put(skb, size), buf, size);

		if (!_rtl8822be_send_bcn_or_cmd_packet(rtlpriv->hw, skb, BEACON_QUEUE))