Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e7a9e8e authored by Viraj Shah's avatar Viraj Shah Committed by Greg Kroah-Hartman
Browse files

usb: musb: Balance list entry in musb_gadget_queue 



commit 21b5fcdccb32ff09b6b63d4a83c037150665a83f upstream.

musb_gadget_queue() adds the passed request to musb_ep::req_list. If the
endpoint is idle and it is the first request then it invokes
musb_queue_resume_work(). If the function returns an error then the
error is passed to the caller without any clean-up and the request
remains enqueued on the list. If the caller enqueues the request again
then the list corrupts.

Remove the request from the list on error.

Fixes: ea2f35c0 ("usb: musb: Fix sleeping function called from invalid context for hdrc glue")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarViraj Shah <viraj.shah@linutronix.de>
Link: https://lore.kernel.org/r/20211021093644.4734-1-viraj.shah@linutronix.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3d24b7a5

drivers/usb/musb/musb_gadget.c

+3 −1
Original line number Diff line number Diff line
@@ -1248,9 +1248,11 @@ static int musb_gadget_queue(struct usb_ep *ep, struct usb_request *req, 
		status = musb_queue_resume_work(musb,

						musb_ep_restart_resume_work,

						request);

		if (status < 0)

		if (status < 0) {

			dev_err(musb->controller, "%s resume work: %i\n",

				__func__, status);

			list_del(&request->list);

		}

	}



unlock: