Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e5bffa5 authored by Lior David's avatar Lior David Committed by Greg Kroah-Hartman
Browse files

wil6210: fix memory leak in wil_find_tx_bcast_2 



[ Upstream commit 664497400c89a4d40aee51bcf48bbd2e4dc71104 ]

A successful call to wil_tx_ring takes skb reference so
it will only be freed in wil_tx_complete. Consume the skb
in wil_find_tx_bcast_2 to prevent memory leak.

Signed-off-by: default avatarLior David <liord@codeaurora.org>
Signed-off-by: default avatarMaya Erez <merez@codeaurora.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 8edf1df1

drivers/net/wireless/ath/wil6210/txrx.c

+2 −0
Original line number Diff line number Diff line
@@ -1313,6 +1313,8 @@ static struct wil_ring *wil_find_tx_bcast_2(struct wil6210_priv *wil, 
			wil_dbg_txrx(wil, "BCAST DUP -> ring %d\n", i);

			wil_set_da_for_vring(wil, skb2, i);

			wil_tx_ring(wil, vif, v2, skb2);

			/* successful call to wil_tx_ring takes skb2 ref */

			dev_kfree_skb_any(skb2);

		} else {

			wil_err(wil, "skb_copy failed\n");

		}