Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e5af074 authored by Hyunwoo Kim's avatar Hyunwoo Kim Committed by Greg Kroah-Hartman
Browse files

media: ttusb-dec: fix memory leak in ttusb_dec_exit_dvb() 

[ Upstream commit 517a281338322ff8293f988771c98aaa7205e457 ]

Since dvb_frontend_detach() is not called in ttusb_dec_exit_dvb(),
which is called when the device is disconnected, dvb_frontend_free()
is not finally called.

This causes a memory leak just by repeatedly plugging and
unplugging the device.

Fix this issue by adding dvb_frontend_detach() to ttusb_dec_exit_dvb().

Link: https://lore.kernel.org/linux-media/20221117045925.14297-5-imv4bel@gmail.com


Signed-off-by: default avatarHyunwoo Kim <imv4bel@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ef4251e3

drivers/media/usb/ttusb-dec/ttusb_dec.c

+1 −2
Original line number Diff line number Diff line
@@ -1561,8 +1561,7 @@ static void ttusb_dec_exit_dvb(struct ttusb_dec *dec) 
	dvb_dmx_release(&dec->demux);

	if (dec->fe) {

		dvb_unregister_frontend(dec->fe);

		if (dec->fe->ops.release)

			dec->fe->ops.release(dec->fe);

		dvb_frontend_detach(dec->fe);

	}

	dvb_unregister_adapter(&dec->adapter);

}