Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e4d6f91 authored by Colin Ian King's avatar Colin Ian King Committed by Doug Ledford
Browse files

RDMA/cxgb3: remove redundant first assignement of sqp 



sqp is being initialised when it is being declared and then updated
a little later on making the first initialization redundant. Clean
this up by initializing ptr and sqp at their declaration.

Cleans up warning: "warning: Value stored to 'sqp' during its
initialization is never read"

Fixes: a58e58fa ("RDMA/cxgb3: Wrap the software send queue pointer as needed on flush")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarSteve Wise <swise@opengridcomputing.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 40a20339

drivers/infiniband/hw/cxgb3/cxio_hal.c

+2 −4
Original line number Diff line number Diff line
@@ -404,12 +404,10 @@ static void insert_sq_cqe(struct t3_wq *wq, struct t3_cq *cq, 


int cxio_flush_sq(struct t3_wq *wq, struct t3_cq *cq, int count)

{

	__u32 ptr;

	__u32 ptr = wq->sq_rptr + count;

	int flushed = 0;

	struct t3_swsq *sqp = wq->sq + Q_PTR2IDX(wq->sq_rptr, wq->sq_size_log2);

	struct t3_swsq *sqp = wq->sq + Q_PTR2IDX(ptr, wq->sq_size_log2);



	ptr = wq->sq_rptr + count;

	sqp = wq->sq + Q_PTR2IDX(ptr, wq->sq_size_log2);

	while (ptr != wq->sq_wptr) {

		sqp->signaled = 0;

		insert_sq_cqe(wq, cq, sqp);