Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d61677c authored by Chuck Lever's avatar Chuck Lever Committed by Doug Ledford
Browse files

svcrdma: Clean up rdma_create_xprt() 



kzalloc is used here, so setting the atomic fields to zero is
unnecessary. sc_ord is set again in handle_connect_req. The other
fields are re-initialized in svc_rdma_accept().

Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Acked-by: default avatarBruce Fields <bfields@fieldses.org>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent c3efe750

net/sunrpc/xprtrdma/svc_rdma_transport.c

+1 −8
Original line number Diff line number Diff line
@@ -529,14 +529,6 @@ static struct svcxprt_rdma *rdma_create_xprt(struct svc_serv *serv, 
	spin_lock_init(&cma_xprt->sc_rq_dto_lock);

	spin_lock_init(&cma_xprt->sc_frmr_q_lock);



	cma_xprt->sc_ord = svcrdma_ord;



	cma_xprt->sc_max_req_size = svcrdma_max_req_size;

	cma_xprt->sc_max_requests = svcrdma_max_requests;

	cma_xprt->sc_sq_depth = svcrdma_max_requests * RPCRDMA_SQ_DEPTH_MULT;

	atomic_set(&cma_xprt->sc_sq_count, 0);

	atomic_set(&cma_xprt->sc_ctxt_used, 0);



	if (listener)

		set_bit(XPT_LISTENER, &cma_xprt->sc_xprt.xpt_flags);
@@ -918,6 +910,7 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt) 
				  (size_t)RPCSVC_MAXPAGES);

	newxprt->sc_max_sge_rd = min_t(size_t, dev->attrs.max_sge_rd,

				       RPCSVC_MAXPAGES);

	newxprt->sc_max_req_size = svcrdma_max_req_size;

	newxprt->sc_max_requests = min((size_t)dev->attrs.max_qp_wr,

				   (size_t)svcrdma_max_requests);

	newxprt->sc_sq_depth = RPCRDMA_SQ_DEPTH_MULT * newxprt->sc_max_requests;