Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d5ae269 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

RDMA/mlx4: Prevent shift wrapping in set_user_sq_size() 



[ Upstream commit d50b3c73f1ac20dabc53dc6e9d64ce9c79a331eb ]

The ucmd->log_sq_bb_count variable is controlled by the user so this
shift can wrap.  Fix it by using check_shl_overflow() in the same way
that it was done in commit 515f60004ed9 ("RDMA/hns: Prevent undefined
behavior in hns_roce_set_user_sq_size()").

Fixes: 83904132 ("IB/mlx4: Sanity check userspace send queue sizes")
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/a8dfbd1d-c019-4556-930b-bab1ded73b10@kili.mountain


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 401794fa

drivers/infiniband/hw/mlx4/qp.c

+6 −2
Original line number Diff line number Diff line
@@ -436,9 +436,13 @@ static int set_user_sq_size(struct mlx4_ib_dev *dev, 
			    struct mlx4_ib_qp *qp,

			    struct mlx4_ib_create_qp *ucmd)

{

	u32 cnt;



	/* Sanity check SQ size before proceeding */

	if ((1 << ucmd->log_sq_bb_count) > dev->dev->caps.max_wqes	 ||

	    ucmd->log_sq_stride >

	if (check_shl_overflow(1, ucmd->log_sq_bb_count, &cnt) ||

	    cnt > dev->dev->caps.max_wqes)

		return -EINVAL;

	if (ucmd->log_sq_stride >

		ilog2(roundup_pow_of_two(dev->dev->caps.max_sq_desc_sz)) ||

	    ucmd->log_sq_stride < MLX4_IB_MIN_SQ_STRIDE)

		return -EINVAL;