Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d2f98a6 authored by Mark Haverkamp's avatar Mark Haverkamp Committed by James Bottomley
Browse files

[SCSI] aacraid: Fix parenthesis placement error 



Received from Mark Salyzyn

On 64 bit machines, when a 32 bit application tries to acquire the AIF,
they will always get and EFAULT error response from the driver.

Signed-off-by: default avatarMark Haverkamp <markh@osdl.org>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent d1ad94ad

drivers/scsi/aacraid/linit.c

+2 −2
Original line number Diff line number Diff line
@@ -571,12 +571,12 @@ static long aac_compat_do_ioctl(struct aac_dev *dev, unsigned cmd, unsigned long 
		

		f = compat_alloc_user_space(sizeof(*f));

		ret = 0;

		if (clear_user(f, sizeof(*f) != sizeof(*f)))

		if (clear_user(f, sizeof(*f)) != sizeof(*f))

			ret = -EFAULT;

		if (copy_in_user(f, (void __user *)arg, sizeof(struct fib_ioctl) - sizeof(u32)))

			ret = -EFAULT;

		if (!ret)

			ret = aac_do_ioctl(dev, cmd, (void __user *)arg);

			ret = aac_do_ioctl(dev, cmd, f);

		break;

	}