Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d06bf42 authored by Jani Nikula's avatar Jani Nikula
Browse files

drm/i915/dvo: fix debug logging on unknown DID 



Print DID not VID on the DID error path. Looks like a copy-paste error
from the VID error path. Clarify and clean up error logging, making them
distinguishable from each other, while at it.

Reported-by: default avatarPetru Mihancea <petrum@gmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101243


Reviewed-by: default avatarClinton Taylor <clinton.a.taylor@intel.com>
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170531101631.26953-1-jani.nikula@intel.com
parent 7618138d

drivers/gpu/drm/i915/dvo_ch7xxx.c

+4 −6
Original line number Diff line number Diff line
@@ -217,8 +217,7 @@ static bool ch7xxx_init(struct intel_dvo_device *dvo, 


	name = ch7xxx_get_id(vendor);

	if (!name) {

		DRM_DEBUG_KMS("ch7xxx not detected; got 0x%02x from %s "

				"slave %d.\n",

		DRM_DEBUG_KMS("ch7xxx not detected; got VID 0x%02x from %s slave %d.\n",

			      vendor, adapter->name, dvo->slave_addr);

		goto out;

	}
@@ -229,9 +228,8 @@ static bool ch7xxx_init(struct intel_dvo_device *dvo, 


	devid = ch7xxx_get_did(device);

	if (!devid) {

		DRM_DEBUG_KMS("ch7xxx not detected; got 0x%02x from %s "

				"slave %d.\n",

			  vendor, adapter->name, dvo->slave_addr);

		DRM_DEBUG_KMS("ch7xxx not detected; got DID 0x%02x from %s slave %d.\n",

			      device, adapter->name, dvo->slave_addr);

		goto out;

	}