Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ceaa141 authored by Jordan Crouse's avatar Jordan Crouse Committed by Rob Clark
Browse files

drm/msm: Removed unused struct_mutex_task 



Recent changes to locking have rendered struct_mutex_task
unused.

Unused since 0e08270a.

Signed-off-by: default avatarJordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: default avatarRob Clark <robdclark@gmail.com>
parent b1fc2839

drivers/gpu/drm/msm/msm_drv.h

+0 −6
Original line number Diff line number Diff line
@@ -154,12 +154,6 @@ struct msm_drm_private { 
	struct shrinker shrinker;



	struct msm_vblank_ctrl vblank_ctrl;



	/* task holding struct_mutex.. currently only used in submit path

	 * to detect and reject faults from copy_from_user() for submit

	 * ioctl.

	 */

	struct task_struct *struct_mutex_task;

};



struct msm_format {

drivers/gpu/drm/msm/msm_gem_submit.c

+0 −2
Original line number Diff line number Diff line
@@ -463,7 +463,6 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, 
			goto out_unlock;

		}

	}

	priv->struct_mutex_task = current;



	submit = submit_create(dev, gpu, queue, args->nr_bos, args->nr_cmds);

	if (!submit) {
@@ -581,7 +580,6 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, 
out_unlock:

	if (ret && (out_fence_fd >= 0))

		put_unused_fd(out_fence_fd);

	priv->struct_mutex_task = NULL;

	mutex_unlock(&dev->struct_mutex);

	return ret;

}