Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3caba98f authored by Milton Miller's avatar Milton Miller Committed by Benjamin Herrenschmidt
Browse files

powerpc/mpic: Simplify ipi cpu mask handling 



Now that MSG_ALL and MSG_ALL_BUT_SELF have been eliminated,
smp_mpic_mesage_pass no longer needs to lookup the cpumask just to
have mpic_send_ipi extract part of it and recode it in a NR_CPUS loop
by mpic_physmask.

Signed-off-by: default avatarMilton Miller <miltonm@bga.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent f1072939

arch/powerpc/sysdev/mpic.c

+11 −13
Original line number Diff line number Diff line
@@ -1613,30 +1613,28 @@ void mpic_request_ipis(void) 
	}

}



static void mpic_send_ipi(unsigned int ipi_no, const struct cpumask *cpu_mask)

void smp_mpic_message_pass(int cpu, int msg)

{

	struct mpic *mpic = mpic_primary;

	u32 physmask;



	BUG_ON(mpic == NULL);



#ifdef DEBUG_IPI

	DBG("%s: send_ipi(ipi_no: %d)\n", mpic->name, ipi_no);

#endif



	mpic_cpu_write(MPIC_INFO(CPU_IPI_DISPATCH_0) +

		       ipi_no * MPIC_INFO(CPU_IPI_DISPATCH_STRIDE),

		       mpic_physmask(cpumask_bits(cpu_mask)[0]));

}



void smp_mpic_message_pass(int cpu, int msg)

{

	/* make sure we're sending something that translates to an IPI */

	if ((unsigned int)msg > 3) {

		printk("SMP %d: smp_message_pass: unknown msg %d\n",

		       smp_processor_id(), msg);

		return;

	}

	mpic_send_ipi(msg, cpumask_of(cpu));



#ifdef DEBUG_IPI

	DBG("%s: send_ipi(ipi_no: %d)\n", mpic->name, msg);

#endif



	physmask = 1 << get_hard_smp_processor_id(cpu);



	mpic_cpu_write(MPIC_INFO(CPU_IPI_DISPATCH_0) +

		       msg * MPIC_INFO(CPU_IPI_DISPATCH_STRIDE), physmask);

}



int __init smp_mpic_probe(void)