Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3caa3751 authored by Masami Hiramatsu's avatar Masami Hiramatsu Committed by Ingo Molnar
Browse files

x86: Use __stop_machine() in text_poke_smp() 



Use __stop_machine() in text_poke_smp() because the caller
must get online_cpus before calling text_poke_smp(), but
stop_machine() do it again. We don't need it.

Signed-off-by: default avatarMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: 2nddept-manager@sdl.hitachi.co.jp
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
LKML-Reference: <20101014031036.4100.83989.stgit@ltc236.sdl.hitachi.co.jp>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 087a4eb5

arch/x86/kernel/alternative.c

+2 −1
Original line number Diff line number Diff line
@@ -637,7 +637,8 @@ void *__kprobes text_poke_smp(void *addr, const void *opcode, size_t len) 
	tpp.len = len;

	atomic_set(&stop_machine_first, 1);

	wrote_text = 0;

	stop_machine(stop_machine_text_poke, (void *)&tpp, NULL);

	/* Use __stop_machine() because the caller already got online_cpus. */

	__stop_machine(stop_machine_text_poke, (void *)&tpp, NULL);

	return addr;

}