Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ca9e5d3 authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Torvalds
Browse files

agp: info leak in agpioc_info_wrap() 



On 64 bit systems the agp_info struct has a 4 byte hole between
->agp_mode and ->aper_base.  We need to clear it to avoid disclosing
stack information to userspace.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent d353efd0

drivers/char/agp/frontend.c

+1 −0
Original line number Diff line number Diff line
@@ -730,6 +730,7 @@ static int agpioc_info_wrap(struct agp_file_private *priv, void __user *arg) 


	agp_copy_info(agp_bridge, &kerninfo);



	memset(&userinfo, 0, sizeof(userinfo));

	userinfo.version.major = kerninfo.version.major;

	userinfo.version.minor = kerninfo.version.minor;

	userinfo.bridge_id = kerninfo.device->vendor |