Commit 3bc7e29c authored Mar 02, 2012 by Arend van Spriel Committed by John W. Linville Mar 05, 2012

brcm80211: fmac: remove unnecessary NULL pointer check



In brcmf_usb_up() the variable devinfo was checked for being
a NULL pointer, but this can not happen. Also the check was done
after dereferencing the pointer. This patch removes the check.

Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Kan Yan <kanyan@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent ebecdcc1

drivers/net/wireless/brcm80211/brcmfmac/usb.c

+0 −3

Original line number	Original line	Diff line number	Diff line
	@@ -712,9 +712,6 @@ static int brcmf_usb_up(struct device *dev)
	struct brcmf_usbdev_info *devinfo = brcmf_usb_get_businfo(dev);		struct brcmf_usbdev_info *devinfo = brcmf_usb_get_businfo(dev);
	u16 ifnum;		u16 ifnum;

	if (devinfo == NULL)
	return -EINVAL;

	if (devinfo->bus_pub.state == BCMFMAC_USB_STATE_UP)		if (devinfo->bus_pub.state == BCMFMAC_USB_STATE_UP)
	return 0;		return 0;