Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3b603066 authored by Yuval Mintz's avatar Yuval Mintz Committed by David S. Miller
Browse files

bnx2x: reduced sparse warnings 



This patch reduces sparse warnings in the bnx2x code,
mostly by changing functions into static and changing
initialization of structures.

Signed-off-by: default avatarYuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: default avatarEilon Greenstein <eilong@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 51c1a580

drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c

+3 −3
Original line number Diff line number Diff line
@@ -1574,7 +1574,7 @@ static inline int bnx2x_init_rss_pf(struct bnx2x *bp) 


int bnx2x_config_rss_pf(struct bnx2x *bp, u8 *ind_table, bool config_hash)

{

	struct bnx2x_config_rss_params params = {0};

	struct bnx2x_config_rss_params params = {NULL};

	int i;



	/* Although RSS is meaningless when there is a single HW queue we
@@ -1637,7 +1637,7 @@ int bnx2x_config_rss_pf(struct bnx2x *bp, u8 *ind_table, bool config_hash) 


static inline int bnx2x_init_hw(struct bnx2x *bp, u32 load_code)

{

	struct bnx2x_func_state_params func_params = {0};

	struct bnx2x_func_state_params func_params = {NULL};



	/* Prepare parameters for function state transitions */

	__set_bit(RAMROD_COMP_WAIT, &func_params.ramrod_flags);
@@ -1658,7 +1658,7 @@ static void bnx2x_squeeze_objects(struct bnx2x *bp) 
{

	int rc;

	unsigned long ramrod_flags = 0, vlan_mac_flags = 0;

	struct bnx2x_mcast_ramrod_params rparam = {0};

	struct bnx2x_mcast_ramrod_params rparam = {NULL};

	struct bnx2x_vlan_mac_obj *mac_obj = &bp->fp->mac_obj;



	/***************** Cleanup MACs' object first *************************/

drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h

+3 −2
Original line number Diff line number Diff line
@@ -970,7 +970,7 @@ static inline void bnx2x_reuse_rx_data(struct bnx2x_fastpath *fp, 
 */

static inline int bnx2x_func_start(struct bnx2x *bp)

{

	struct bnx2x_func_state_params func_params = {0};

	struct bnx2x_func_state_params func_params = {NULL};

	struct bnx2x_func_start_params *start_params =

		&func_params.params.start;
@@ -1596,6 +1596,7 @@ static inline void bnx2x_bz_fp(struct bnx2x *bp, int index) 
#endif

}



#ifdef BCM_CNIC

/**

 * bnx2x_get_iscsi_info - update iSCSI params according to licensing info.

 *
@@ -1603,7 +1604,7 @@ static inline void bnx2x_bz_fp(struct bnx2x *bp, int index) 
 *

 */

void bnx2x_get_iscsi_info(struct bnx2x *bp);



#endif

/* returns func by VN for current port */

static inline int func_by_vn(struct bnx2x *bp, int vn)

{

drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c

+3 −3
Original line number Diff line number Diff line
@@ -443,7 +443,7 @@ static void bnx2x_pfc_set_pfc(struct bnx2x *bp) 


static int bnx2x_dcbx_stop_hw_tx(struct bnx2x *bp)

{

	struct bnx2x_func_state_params func_params = {0};

	struct bnx2x_func_state_params func_params = {NULL};



	func_params.f_obj = &bp->func_obj;

	func_params.cmd = BNX2X_F_CMD_TX_STOP;
@@ -454,7 +454,7 @@ static int bnx2x_dcbx_stop_hw_tx(struct bnx2x *bp) 


static int bnx2x_dcbx_resume_hw_tx(struct bnx2x *bp)

{

	struct bnx2x_func_state_params func_params = {0};

	struct bnx2x_func_state_params func_params = {NULL};

	struct bnx2x_func_tx_start_params *tx_params =

		&func_params.params.tx_start;
@@ -529,7 +529,7 @@ static void bnx2x_dcbx_2cos_limit_update_ets_config(struct bnx2x *bp) 
/*

 * In E3B0 the configuration may have more than 2 COS.

 */

void bnx2x_dcbx_update_ets_config(struct bnx2x *bp)

static void bnx2x_dcbx_update_ets_config(struct bnx2x *bp)

{

	struct bnx2x_dcbx_pg_params *ets = &(bp->dcbx_port_params.ets);

	struct bnx2x_ets_params ets_params = { 0 };

drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c

+1 −1
Original line number Diff line number Diff line
@@ -2107,7 +2107,7 @@ static int bnx2x_test_nvram(struct bnx2x *bp) 
/* Send an EMPTY ramrod on the first queue */

static int bnx2x_test_intr(struct bnx2x *bp)

{

	struct bnx2x_queue_state_params params = {0};

	struct bnx2x_queue_state_params params = {NULL};



	if (!netif_running(bp->dev)) {

		DP(BNX2X_MSG_ETHTOOL | BNX2X_MSG_NVM,

drivers/net/ethernet/broadcom/bnx2x/bnx2x_fw_defs.h

+0 −12
Original line number Diff line number Diff line
@@ -243,18 +243,6 @@ 
	(IRO[48].base + ((funcId) * IRO[48].m1))

#define COMMON_ASM_INVALID_ASSERT_OPCODE 0x0



/**

* This file defines HSI constants for the ETH flow

*/

#ifdef _EVEREST_MICROCODE

#include "Microcode\Generated\DataTypes\eth_rx_bd.h"

#include "Microcode\Generated\DataTypes\eth_tx_bd.h"

#include "Microcode\Generated\DataTypes\eth_rx_cqe.h"

#include "Microcode\Generated\DataTypes\eth_rx_sge.h"

#include "Microcode\Generated\DataTypes\eth_rx_cqe_next_page.h"

#endif





/* Ethernet Ring parameters */

#define X_ETH_LOCAL_RING_SIZE 13

#define FIRST_BD_IN_PKT	0