Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3a6b7666 authored by Srikar Dronamraju's avatar Srikar Dronamraju Committed by Ingo Molnar
Browse files

tracing: Modify is_delete, is_return from int to bool 



is_delete and is_return can take utmost 2 values and are better
of being a boolean than a int. There are no functional changes.

Signed-off-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
Acked-by: default avatarSteven Rostedt <rostedt@goodmis.org>
Acked-by: default avatarMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Jim Keniston <jkenisto@linux.vnet.ibm.com>
Cc: Linux-mm <linux-mm@kvack.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: Anton Arapov <anton@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20120409091133.8343.65289.sendpatchset@srdronam.in.ibm.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent cbc91f71

kernel/trace/trace_kprobe.c

+8 −8
Original line number Diff line number Diff line
@@ -651,7 +651,7 @@ static struct trace_probe *alloc_trace_probe(const char *group, 
					     void *addr,

					     const char *symbol,

					     unsigned long offs,

					     int nargs, int is_return)

					     int nargs, bool is_return)

{

	struct trace_probe *tp;

	int ret = -ENOMEM;
@@ -944,7 +944,7 @@ static int split_symbol_offset(char *symbol, unsigned long *offset) 
#define PARAM_MAX_STACK (THREAD_SIZE / sizeof(unsigned long))



static int parse_probe_vars(char *arg, const struct fetch_type *t,

			    struct fetch_param *f, int is_return)

			    struct fetch_param *f, bool is_return)

{

	int ret = 0;

	unsigned long param;
@@ -977,7 +977,7 @@ static int parse_probe_vars(char *arg, const struct fetch_type *t, 


/* Recursive argument parser */

static int __parse_probe_arg(char *arg, const struct fetch_type *t,

			     struct fetch_param *f, int is_return)

			     struct fetch_param *f, bool is_return)

{

	int ret = 0;

	unsigned long param;
@@ -1089,7 +1089,7 @@ static int __parse_bitfield_probe_arg(const char *bf, 


/* String length checking wrapper */

static int parse_probe_arg(char *arg, struct trace_probe *tp,

			   struct probe_arg *parg, int is_return)

			   struct probe_arg *parg, bool is_return)

{

	const char *t;

	int ret;
@@ -1162,7 +1162,7 @@ static int create_trace_probe(int argc, char **argv) 
	 */

	struct trace_probe *tp;

	int i, ret = 0;

	int is_return = 0, is_delete = 0;

	bool is_return = false, is_delete = false;

	char *symbol = NULL, *event = NULL, *group = NULL;

	char *arg;

	unsigned long offset = 0;
@@ -1171,11 +1171,11 @@ static int create_trace_probe(int argc, char **argv) 


	/* argc must be >= 1 */

	if (argv[0][0] == 'p')

		is_return = 0;

		is_return = false;

	else if (argv[0][0] == 'r')

		is_return = 1;

		is_return = true;

	else if (argv[0][0] == '-')

		is_delete = 1;

		is_delete = true;

	else {

		pr_info("Probe definition must be started with 'p', 'r' or"

			" '-'.\n");