Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 39fba783 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

kaweth: use skb_cow_head() to deal with cloned skbs 



We can use skb_cow_head() to properly deal with clones,
especially the ones coming from TCP stack that allow their head being
modified. This avoids a copy.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: James Hughes <james.hughes@raspberrypi.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6bc6895b

drivers/net/usb/kaweth.c

+6 −12
Original line number Diff line number Diff line
@@ -803,19 +803,13 @@ static netdev_tx_t kaweth_start_xmit(struct sk_buff *skb, 
	}



	/* We now decide whether we can put our special header into the sk_buff */

	if (skb_cloned(skb) || skb_headroom(skb) < 2) {

		/* no such luck - we make our own */

		struct sk_buff *copied_skb;

		copied_skb = skb_copy_expand(skb, 2, 0, GFP_ATOMIC);

		dev_kfree_skb_irq(skb);

		skb = copied_skb;

		if (!copied_skb) {

	if (skb_cow_head(skb, 2)) {

		kaweth->stats.tx_errors++;

		netif_start_queue(net);

		spin_unlock_irq(&kaweth->device_lock);

		dev_kfree_skb_any(skb);

		return NETDEV_TX_OK;

	}

	}



	private_header = (__le16 *)__skb_push(skb, 2);

	*private_header = cpu_to_le16(skb->len-2);