Commit 39c421cb authored Sep 25, 2019 by Dan Carpenter Committed by Greg Kroah-Hartman Jan 27, 2020

net: stmmac: dwmac-meson8b: Fix signedness bug in probe



[ Upstream commit f10210517a2f37feea2edf85eb34c98977265c16 ]

The "dwmac->phy_mode" is an enum and in this context GCC treats it as
an unsigned int so the error handling is never triggered.

Fixes: 566e8251 ("net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 9724794c

drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -355,7 +355,7 @@ static int meson8b_dwmac_probe(struct platform_device *pdev)

		dwmac->dev = &pdev->dev;
		dwmac->phy_mode = of_get_phy_mode(pdev->dev.of_node);
		if (dwmac->phy_mode < 0) {
		if ((int)dwmac->phy_mode < 0) {
		dev_err(&pdev->dev, "missing phy-mode property\n");
		ret = -EINVAL;
		goto err_remove_config_dt;