Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 393fb560 authored by Ido Yariv's avatar Ido Yariv Committed by Luciano Coelho
Browse files

wl12xx: Change claiming of the SDIO bus 



The SDIO bus is claimed and released for each SDIO transaction. In
addition to the few CPU cycles it takes to claim and release the bus, it
may also cause undesired side effects such as the MMC host stopping its
internal clocks.

Since only the wl12xx_sdio driver drives this SDIO card, it is safe to
claim the SDIO host once (on power on), and release it only when turning
the power off.

This patch was inspired by Juuso Oikarinen's (juuso.oikarinen@nokia.com)
patch "wl12xx: Change claiming of the (SDIO) bus".

Signed-off-by: default avatarIdo Yariv <ido@wizery.com>
Reviewed-by: default avatarLuciano Coelho <coelho@ti.com>
Signed-off-by: default avatarLuciano Coelho <coelho@ti.com>
parent 606ea9fa

drivers/net/wireless/wl12xx/sdio.c

+0 −10
Original line number Diff line number Diff line
@@ -107,8 +107,6 @@ static void wl1271_sdio_raw_read(struct wl1271 *wl, int addr, void *buf, 
	int ret;

	struct sdio_func *func = wl_to_func(wl);



	sdio_claim_host(func);



	if (unlikely(addr == HW_ACCESS_ELP_CTRL_REG_ADDR)) {

		((u8 *)buf)[0] = sdio_f0_readb(func, addr, &ret);

		wl1271_debug(DEBUG_SDIO, "sdio read 52 addr 0x%x, byte 0x%02x",
@@ -124,8 +122,6 @@ static void wl1271_sdio_raw_read(struct wl1271 *wl, int addr, void *buf, 
		wl1271_dump_ascii(DEBUG_SDIO, "data: ", buf, len);

	}



	sdio_release_host(func);



	if (ret)

		wl1271_error("sdio read failed (%d)", ret);

}
@@ -136,8 +132,6 @@ static void wl1271_sdio_raw_write(struct wl1271 *wl, int addr, void *buf, 
	int ret;

	struct sdio_func *func = wl_to_func(wl);



	sdio_claim_host(func);



	if (unlikely(addr == HW_ACCESS_ELP_CTRL_REG_ADDR)) {

		sdio_f0_writeb(func, ((u8 *)buf)[0], addr, &ret);

		wl1271_debug(DEBUG_SDIO, "sdio write 52 addr 0x%x, byte 0x%02x",
@@ -153,8 +147,6 @@ static void wl1271_sdio_raw_write(struct wl1271 *wl, int addr, void *buf, 
			ret = sdio_memcpy_toio(func, addr, buf, len);

	}



	sdio_release_host(func);



	if (ret)

		wl1271_error("sdio write failed (%d)", ret);

}
@@ -176,7 +168,6 @@ static int wl1271_sdio_power_on(struct wl1271 *wl) 


	sdio_claim_host(func);

	sdio_enable_func(func);

	sdio_release_host(func);



out:

	return ret;
@@ -187,7 +178,6 @@ static int wl1271_sdio_power_off(struct wl1271 *wl) 
	struct sdio_func *func = wl_to_func(wl);

	int ret;



	sdio_claim_host(func);

	sdio_disable_func(func);

	sdio_release_host(func);