Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38e712ab authored by Julia Lawall's avatar Julia Lawall Committed by Alex Elder
Browse files

fs/xfs/quota: Add missing mutex_unlock

Add a mutex_unlock missing on the error path.  The use of this lock
is balanced elsewhere in the file.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression E1;
@@

* mutex_lock(E1,...);
  <+... when != E1
  if (...) {
    ... when != E1
*   return ...;
  }
  ...+>
* mutex_unlock(E1,...);
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
parent 3bd0946e
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -249,9 +249,11 @@ xfs_qm_hold_quotafs_ref(

	if (!xfs_Gqm) {
		xfs_Gqm = xfs_Gqm_init();
		if (!xfs_Gqm)
		if (!xfs_Gqm) {
			mutex_unlock(&xfs_Gqm_lock);
			return ENOMEM;
		}
	}

	/*
	 * We can keep a list of all filesystems with quotas mounted for