Commit 38d8ed65 authored Oct 23, 2016 by Colin Ian King Committed by Guenter Roeck Oct 24, 2016

hwmon: (core) fix resource leak on devm_kcalloc failure



If dev_kcalloc fails to allocate hw_dev->groups then the current
exit path is a direct return, causing a leak of resources such
as hwdev and ida is not removed.  Fix this by exiting via the
free_hwmon exit path that performs the necessary resource cleanup.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 07d9a380

drivers/hwmon/hwmon.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -536,8 +536,10 @@ __hwmon_device_register(struct device dev, const char name, void *drvdata,

		hwdev->groups = devm_kcalloc(dev, ngroups, sizeof(*groups),
		GFP_KERNEL);
		if (!hwdev->groups)
		return ERR_PTR(-ENOMEM);
		if (!hwdev->groups) {
		err = -ENOMEM;
		goto free_hwmon;
		}

		attrs = __hwmon_create_attrs(dev, drvdata, chip);
		if (IS_ERR(attrs)) {