Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38a90e7c authored by Markus Elfring's avatar Markus Elfring Committed by David S. Miller
Browse files

net: Xilinx: Deletion of unnecessary checks before two function calls 



The functions kfree() and of_node_put() test whether their argument is NULL
and then return immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Reviewed-by: default avatarSoren Brinkmann <soren.brinkmann@xilinx.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5ac0fd00

drivers/net/ethernet/xilinx/ll_temac_main.c

+1 −2
Original line number Diff line number Diff line
@@ -224,7 +224,6 @@ static void temac_dma_bd_release(struct net_device *ndev) 
		dma_free_coherent(ndev->dev.parent,

				sizeof(*lp->tx_bd_v) * TX_BD_NUM,

				lp->tx_bd_v, lp->tx_bd_p);

	if (lp->rx_skb)

	kfree(lp->rx_skb);

}

drivers/net/ethernet/xilinx/xilinx_emaclite.c

+1 −2
Original line number Diff line number Diff line
@@ -1200,7 +1200,6 @@ static int xemaclite_of_remove(struct platform_device *of_dev) 


	unregister_netdev(ndev);



	if (lp->phy_node)

	of_node_put(lp->phy_node);

	lp->phy_node = NULL;