Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3834630e authored by Hui Wang's avatar Hui Wang Committed by Greg Kroah-Hartman
Browse files

ALSA: hda/realtek - Improve the headset mic for Acer Aspire laptops 

commit 9cb40eb184c4220d244a532bd940c6345ad9dbd9 upstream.

We met another Acer Aspire laptop which has the problem on the
headset-mic, the Pin 0x19 is not set the corret configuration for a
mic and the pin presence can't be detected too after plugging a
headset. Kailang suggested that we should set the coeff to enable the
mic and apply the ALC269_FIXUP_LIFEBOOK_EXTMIC. After doing that,
both headset-mic presence and headset-mic work well.

The existing ALC255_FIXUP_ACER_MIC_NO_PRESENCE set the headset-mic
jack to be a phantom jack. Now since the jack can support presence
unsol event, let us imporve it to set the jack to be a normal jack.

https://bugs.launchpad.net/bugs/1821269


Fixes: 5824ce8d ("ALSA: hda/realtek - Add support for Acer Aspire E5-475 headset mic")
Cc: Chris Chiu <chiu@endlessm.com>
CC: Daniel Drake <drake@endlessm.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarKailang Yang <kailang@realtek.com>
Signed-off-by: default avatarHui Wang <hui.wang@canonical.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9cfd6c36

sound/pci/hda/patch_realtek.c

+11 −5
Original line number Diff line number Diff line
@@ -6084,13 +6084,15 @@ static const struct hda_fixup alc269_fixups[] = { 
		.chain_id = ALC269_FIXUP_THINKPAD_ACPI,

	},

	[ALC255_FIXUP_ACER_MIC_NO_PRESENCE] = {

		.type = HDA_FIXUP_PINS,

		.v.pins = (const struct hda_pintbl[]) {

			{ 0x19, 0x01a1913c }, /* use as headset mic, without its own jack detect */

		.type = HDA_FIXUP_VERBS,

		.v.verbs = (const struct hda_verb[]) {

			/* Enable the Mic */

			{ 0x20, AC_VERB_SET_COEF_INDEX, 0x45 },

			{ 0x20, AC_VERB_SET_PROC_COEF, 0x5089 },

			{}

		},

		.chained = true,

		.chain_id = ALC255_FIXUP_HEADSET_MODE

		.chain_id = ALC269_FIXUP_LIFEBOOK_EXTMIC

	},

	[ALC255_FIXUP_ASUS_MIC_NO_PRESENCE] = {

		.type = HDA_FIXUP_PINS,
@@ -7121,6 +7123,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { 
		{0x18, 0x02a11030},

		{0x19, 0x0181303F},

		{0x21, 0x0221102f}),

	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1025, "Acer", ALC255_FIXUP_ACER_MIC_NO_PRESENCE,

		{0x12, 0x90a60140},

		{0x14, 0x90170120},

		{0x21, 0x02211030}),

	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1025, "Acer", ALC255_FIXUP_ACER_MIC_NO_PRESENCE,

		{0x12, 0x90a601c0},

		{0x14, 0x90171120},