Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38316c8a authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Torvalds
Browse files

fs/compat_ioctl.c: fix an underflow issue (harmless) 



We cap "nmsgs" at I2C_RDRW_IOCTL_MAX_MSGS (42) but the current code
allows negative values.  It's harmless but it makes my static checker
upset so I've made nsmgs unsigned.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0afaa120

fs/compat_ioctl.c

+2 −1
Original line number Diff line number Diff line
@@ -680,7 +680,8 @@ static int do_i2c_rdwr_ioctl(unsigned int fd, unsigned int cmd, 
	struct i2c_msg			__user *tmsgs;

	struct i2c_msg32		__user *umsgs;

	compat_caddr_t			datap;

	int				nmsgs, i;

	u32				nmsgs;

	int				i;



	if (get_user(nmsgs, &udata->nmsgs))

		return -EFAULT;