Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38189779 authored by YueHaibing's avatar YueHaibing Committed by David S. Miller
Browse files

net/smc: fix sizeof to int comparison 



Comparing an int to a size, which is unsigned, causes the int to become
unsigned, giving the wrong result. kernel_sendmsg can return a negative
error code.

Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarUrsula Braun <ubraun@linux.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 71d117f5

net/smc/smc_clc.c

+6 −8
Original line number Diff line number Diff line
@@ -446,14 +446,12 @@ int smc_clc_send_proposal(struct smc_sock *smc, int smc_type, 
	vec[i++].iov_len = sizeof(trl);

	/* due to the few bytes needed for clc-handshake this cannot block */

	len = kernel_sendmsg(smc->clcsock, &msg, vec, i, plen);

	if (len < sizeof(pclc)) {

		if (len >= 0) {

			reason_code = -ENETUNREACH;

			smc->sk.sk_err = -reason_code;

		} else {

	if (len < 0) {

		smc->sk.sk_err = smc->clcsock->sk->sk_err;

		reason_code = -smc->sk.sk_err;

		}

	} else if (len < (int)sizeof(pclc)) {

		reason_code = -ENETUNREACH;

		smc->sk.sk_err = -reason_code;

	}



	return reason_code;