Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 37f85b27 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab
Browse files

[media] uvcvideo: Fix incorrect bandwidth with Chicony device 04f2:b50b 



The "TOSHIBA Web Camera - 5M" Chicony device (04f2:b50b) seems to
compute the bandwidth on 16 bits and erroneously sign-extend it to
32 bits, resulting in a huge bandwidth value. Detect and fix that
condition by setting the 16 MSBs to 0 when they're all equal to 1.

Reported-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 7195f61b

drivers/media/usb/uvc/uvc_video.c

+8 −0
Original line number Diff line number Diff line
@@ -119,6 +119,14 @@ static void uvc_fixup_video_ctrl(struct uvc_streaming *stream, 
		ctrl->dwMaxVideoFrameSize =

			frame->dwMaxVideoFrameBufferSize;



	/* The "TOSHIBA Web Camera - 5M" Chicony device (04f2:b50b) seems to

	 * compute the bandwidth on 16 bits and erroneously sign-extend it to

	 * 32 bits, resulting in a huge bandwidth value. Detect and fix that

	 * condition by setting the 16 MSBs to 0 when they're all equal to 1.

	 */

	if ((ctrl->dwMaxPayloadTransferSize & 0xffff0000) == 0xffff0000)

		ctrl->dwMaxPayloadTransferSize &= ~0xffff0000;



	if (!(format->flags & UVC_FMT_FLAG_COMPRESSED) &&

	    stream->dev->quirks & UVC_QUIRK_FIX_BANDWIDTH &&

	    stream->intf->num_altsetting > 1) {