Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 37df0949 authored by Hui Wang's avatar Hui Wang Committed by Takashi Iwai
Browse files

Revert "ALSA: hda - drop def association and sequence from pinconf comparing" 



This reverts commit c687200b.

Dropping the def association and sequence from pinconf comparing is a
bit risky, It will introduce a greater risk of catching unwanted
machines.

And in addition, so far no BIOS experts give us an explicit answer
whether it makes senses to compare these two fields or not.

For safety reason, we revert this commit.

Signed-off-by: default avatarHui Wang <hui.wang@canonical.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 39617837

sound/pci/hda/hda_auto_parser.c

+1 −2
Original line number Diff line number Diff line
@@ -844,8 +844,7 @@ static bool pin_config_match(struct hda_codec *codec, 
{

	for (; pins->nid; pins++) {

		u32 def_conf = snd_hda_codec_get_pincfg(codec, pins->nid);

		u32 mask = 0xffffff00;

		if ((pins->val & mask) != (def_conf & mask))

		if (pins->val != def_conf)

			return false;

	}

	return true;