Commit 377aa6b0 authored Jun 14, 2017 by Alistair Popple Committed by Michael Ellerman Jun 14, 2017

powerpc/npu-dma: Remove spurious WARN_ON when a PCI device has no of_node



Commit 4c3b89ef ("powerpc/powernv: Add sanity checks to
pnv_pci_get_{gpu|npu}_dev") introduced explicit warnings in
pnv_pci_get_npu_dev() when a PCIe device has no associated device-tree
node. However not all PCIe devices have an of_node and
pnv_pci_get_npu_dev() gets indirectly called at least once for every
PCIe device in the system. This results in spurious WARN_ON()'s so
remove it.

The same situation should not exist for pnv_pci_get_gpu_dev() as any
NPU based PCIe device requires a device-tree node.

Fixes: 4c3b89ef ("powerpc/powernv: Add sanity checks to pnv_pci_get_{gpu|npu}_dev")
Reported-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Alistair Popple <alistair@popple.id.au>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent c6ee9619

arch/powerpc/platforms/powernv/npu-dma.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -75,7 +75,8 @@ struct pci_dev pnv_pci_get_npu_dev(struct pci_dev gpdev, int index)
		if (WARN_ON(!gpdev))
		return NULL;

		if (WARN_ON(!gpdev->dev.of_node))
		/* Not all PCI devices have device-tree nodes */
		if (!gpdev->dev.of_node)
		return NULL;

		/* Get assoicated PCI device */