Commit 37232abb authored Jun 17, 2019 by Colin Ian King Committed by Greg Kroah-Hartman Jul 14, 2019

net: lio_core: fix potential sign-extension overflow on large shift



[ Upstream commit 9476274093a0e79b905f4cd6cf6d149f65e02c17 ]

Left shifting the signed int value 1 by 31 bits has undefined behaviour
and the shift amount oq_no can be as much as 63.  Fix this by using
BIT_ULL(oq_no) instead.

Addresses-Coverity: ("Bad shift operation")
Fixes: f21fb3ed ("Add support of Cavium Liquidio ethernet adapters")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 740b2ac4

drivers/net/ethernet/cavium/liquidio/lio_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -985,7 +985,7 @@ static void liquidio_schedule_droq_pkt_handlers(struct octeon_device *oct)

		if (droq->ops.poll_mode) {
		droq->ops.napi_fn(droq);
		oct_priv->napi_mask \|= (1 << oq_no);
		oct_priv->napi_mask \|= BIT_ULL(oq_no);
		} else {
		tasklet_schedule(&oct_priv->droq_tasklet);
		}